Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(deps): update GitHub actions to run on Node.js 20 (LTS) #130

Merged
merged 1 commit into from
Oct 29, 2023
Merged

ci(deps): update GitHub actions to run on Node.js 20 (LTS) #130

merged 1 commit into from
Oct 29, 2023

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Oct 29, 2023 •
edited
Loading

This PR bumps

  • .nvmrc from Node.js 14, which reached end-of-life on Apr 30, 2023, to Node.js 20, which is the current Long Term Support (LTS) version, announced as Node.js v20.9.0 on Oct 24, 2023.

Also in GitHub Actions workflows

the following GitHub Action are bumped

to resolve the GitHub Actions deprecation warning:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

and the planned deprecation of node16 (see blog post GitHub Actions: Transitioning from Node 16 to Node 20 Sep 22, 2023).

@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 29, 2023 13:53
@MikeMcC399
Copy link
Contributor Author

MikeMcC399 commented Oct 29, 2023 •
edited
Loading

Further details

DEP0040 in the History section of the Node.js documentation shows that Node.js punycode has been deprecated since Node.js v7.0.0 and, starting with Node.js v21.0.0, this has been changed to a runtime deprecation (see nodejs/node#47202). The runtime deprecation is causing it to now become visible.

Node.js v21.0.0 was released on Oct 17, 2023 as the first release of the 21.x major version, so the issue is quite new.

Typically the deprecation notice looks like this:

(node:2136) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.
(Use node --trace-deprecation ... to show where the warning was created)

and I'm seeing this appearing in many places, including when Yarn Classic is used to add a package.

@mathiasbynens mathiasbynens merged commit 1287b46 into mathiasbynens:main Oct 29, 2023
1 check passed
@mathiasbynens
Copy link
Owner

Thanks!

@MikeMcC399 MikeMcC399 deleted the ci-node20 branch October 29, 2023 16:35
@MikeMcC399
Copy link
Contributor Author

@mathiasbynens

You're very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeMcC399 @mathiasbynens